Skip to content

Various improvements to the HiGHS interface #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Various improvements to the HiGHS interface #418

wants to merge 21 commits into from

Conversation

@rschwarz
Copy link
Contributor

High-level summary:

  • switched binary library from highspy to highsbox, because highspy was not meant to be used that way, which caused problems on some platforms
  • bugfixes in var_get_index/constr_get_index, when a user asks for a variable/constraint with an invalid name
  • bugfix in set_objective, where we now first reset the objective with all-zero coefficients
  • bugfix in get_var_type, with work-around for purely continuous problems
  • added more tests
  • allow for Python 3.13 (not specific to HiGHS)

rschwarz and others added 19 commits January 16, 2025 22:20
@rschwarz
highs: fix var_get_index for error case
9f7741d
@rschwarz
extend tests for var_by_name
6c5e313
@rschwarz
extend test_objective: add & rm terms
1649c75 
Before, only coefficients were changed. This now fails on HiGHS, which doesn't
properly reset the objective before setting a new one.
@rschwarz
fix SolverHighs.set_objective
3a4bd7b
@rschwarz
highs: add comments about confusion between BINARY and INTEGER
5de89ae
@rschwarz
add test_verbose
a0d4035
@rschwarz
fix SolverHighs._{get,set}_bool_option_value
db1834d 
Used incorrect types before.
@rschwarz
skip tests with HiGHS based on .gz files
bcd8d91
@rschwarz
Merge pull request #2 from Doing-The-Math/rs/highs_fixes
3fb7268 
Rs/highs fixes
@BernardZweers
Return -1 if constraint not found
754c774
@rschwarz
Merge pull request #3 from Doing-The-Math/bz-constraint-idx
ef0805e 
Return -1 if constraint not found
@rschwarz
substitute highsbox for highspy
dd10613
@rschwarz
Merge pull request #5 from Doing-The-Math/rs/highsbox
b683804 
substitute highsbox for highspy
@rschwarz
check status on Highs_getColIntegrality (fail some tests)
c627797
@rschwarz
work around unexpected Highs_getColIntegrality error
77e973a
@rschwarz
Merge pull request #7 from Doing-The-Math/6-fix-failing-tests-query-v…
099bb88 
…ariable-integrality

6 fix failing tests query variable integrality
@miguelhisojo
upgrade python for doing the math fork to python3.13
3c28f0b
@rschwarz
Merge pull request #9 from alliander-opensource/python313
5f7b158 
upgrade python for doing the math fork to python3.13
@rschwarz
Merge remote-tracking branch 'upstream/master'
c2c752d
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rschwarz
Copy link
Contributor Author

rschwarz commented Sep 18, 2025 •
edited
Loading

When I ran tests locally, I got errors (actually crashes) with CBC, but if I just test

pytest -k "not CBC" test/test_model.py test/mip_test.py

It all works fine.

EDIT: See

$ pytest -k CBC test/test_model.py 
===== test session starts =====
platform linux -- Python 3.12.3, pytest-8.4.2, pluggy-1.6.0
rootdir: /home/robert/src/python-mip
configfile: pyproject.toml
plugins: xdist-3.8.0
collected 278 items / 139 deselected / 139 selected                                                                                                                                                                     

test/test_model.py .Aborted (core dumped)

@rschwarz rschwarz mentioned this pull request Sep 18, 2025
Open
@rschwarz
Copy link
Contributor Author

I've also made a change to the pre-commit configuration (upgrade flake8) to avoid an error that happens during the first of the checks.

This was referenced Sep 18, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschwarz @CLAassistant @BernardZweers @miguelhisojo